[codex] Make GitHub auth work through the site proxy#71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
sessionStorageRoot cause
Production tracing during the staged deployment showed that the here.now proxy follows upstream redirects and strips Cookie, Origin, and Referer headers. The original cookie/302 OAuth design therefore could not complete through the canonical domain.
Validation
node scripts/check.mjsDeployment
Deploy the Worker first with
VOTING_UI_ENABLED=false, republish the complete site artifact for the new cache key, complete the canonical GitHub login/session/vote/reload/logout smoke test, then redeploy only the Worker with the flag explicitly enabled.